chore: Make TrinoCatalog.spec.connector.iceberg.metastore optional#841
Merged
chore: Make TrinoCatalog.spec.connector.iceberg.metastore optional#841
TrinoCatalog.spec.connector.iceberg.metastore optional#841Conversation
Member
|
I see no problem with this. We did a similar thing when NiFi no longer needed a ZooKeeper cluster. |
Member
|
Approved during the daily |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: For CRD change see
deploy/helm/trino-operator/crds/crds.yaml.Motivation:
As the Hive metastore connection is currently mandatory, this blocks users from using a Iceberg REST catalog.
I want to do exactly that in the nifi-operator integration tests.
We also had questions for exactly this problem on Discord and problems during the last on-site.
This PR simply makes the field optional, that's it 😅
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features trackerRelease notes
TrinoCatalog.spec.connector.iceberg.metastoreis now optional, as Iceberg also supports other catalogs, such as a REST catalog, which (currently) can only be added using configOverrides